linux-kernel - Re: [PATCH v2 2/3] userfaultfd: convert __mcopy_atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230315195328.GA3092@monkey>
Date:   Wed, 15 Mar 2023 12:53:28 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Peng Zhang <zhangpeng362@...wei.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        willy@...radead.org, akpm@...ux-foundation.org,
        vishal.moola@...il.com, sidhartha.kumar@...cle.com,
        wangkefeng.wang@...wei.com, sunnanyong@...wei.com
Subject: Re: [PATCH v2 2/3] userfaultfd: convert __mcopy_atomic_hugetlb() to
 use a folio

On 03/14/23 13:13, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@...wei.com>
> 
> Change copy_huge_page_from_user() to copy_folio_from_user().

Any reason why you did not change copy_user_huge_page to folios as
well?  All callers are passing &folio->page.

Just my opinion, but it might be better/easier to review if the copy
routines were done in a separate patch.  There is a little more than
folio conversion happening there.

-- 
Mike Kravetz

> Convert hugetlb_mcopy_atomic_pte() and __mcopy_atomic_hugetlb() to use a
> folio.
> 
> Signed-off-by: ZhangPeng <zhangpeng362@...wei.com>
> ---
>  include/linux/hugetlb.h |  4 ++--
>  include/linux/mm.h      |  3 +--
>  mm/hugetlb.c            | 25 ++++++++++++-------------
>  mm/memory.c             | 27 ++++++++++++---------------
>  mm/userfaultfd.c        | 20 +++++++++-----------
>  5 files changed, 36 insertions(+), 43 deletions(-)