linux-kernel - Re: [PATCH] drivers: hwmon: ltc4282: Add support for LTC4282

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <269496bb-ccc2-a853-f6cd-c494433cca0a@roeck-us.net>
Date:   Wed, 15 Mar 2023 14:24:06 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Mohammed Danish Ali <mohammed.danish.ali.14@...il.com>,
        jdelvare@...e.com, corbet@....net, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: hwmon: ltc4282: Add support for LTC4282

On 3/15/23 14:08, Mohammed Danish Ali wrote:
> Date: Wed, 15 Mar 2023 20:48:17 +0000
> 
> Added support for LTC4282: High Current Hot Swap Controller with I2C
> Compatible Monitoring
> 
> Signed-off-by: Mohammed Danish Ali <mohammed.danish.ali.14@...il.com <mailto:mohammed.danish.ali.14@...il.com>>
> ---

...

> +   hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name, data, ltc4282_groups);

include/hwmon/hwmon.h:

/*
  * hwmon_device_register_with_groups() and
  * devm_hwmon_device_register_with_groups() are deprecated.
  */

Documentation/hwmon/submitting-patches.rst:

* Use devm_hwmon_device_register_with_info() or, if your driver needs a remove
   function, hwmon_device_register_with_info() to register your driver with the
   hwmon subsystem. Try using devm_add_action() instead of a remove function if
   possible. Do not use any of the deprecated registration functions.
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Please resubmit.

Thanks,
Guenter