linux-kernel - RE: [PATCH v5 2/2] pinctrl: pinctrl-mlxbf: Add pinctrl driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH2PR12MB38951C5F7140436C118EFD77D7BF9@CH2PR12MB3895.namprd12.prod.outlook.com>
Date:   Wed, 15 Mar 2023 21:45:06 +0000
From:   Asmaa Mnebhi <asmaa@...dia.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "niyas.sait@...aro.org" <niyas.sait@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: RE: [PATCH v5 2/2] pinctrl: pinctrl-mlxbf: Add pinctrl driver support

> > +struct mlxbf3_pinctrl {
> > +       void __iomem *fw_ctrl_set0;
> > +       void __iomem *fw_ctrl_clr0;
> > +       void __iomem *fw_ctrl_set1;
> > +       void __iomem *fw_ctrl_clr1;
> 
> > +       struct device *dev;
> > +       struct pinctrl_dev *pctl;
> 
> Depending on what is used more often in the code you can shuffle the order
> and save a few bytes in the generated code. You may play with bloat-o-
> meter to check.

I moved around some of the structs above and it hasn’t changed the size of the struct. I also played around
With bloat-o-meter to compare the generated .o files and I don’t see a difference.