linux-kernel - Re: [PATCH v6] scsi: ufs: core: Add trace event for MCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1d9e985-9948-6620-d311-cfc590fe89b2@quicinc.com>
Date:   Wed, 15 Mar 2023 15:43:31 +0800
From:   Ziqi Chen <quic_ziqichen@...cinc.com>
To:     Bart Van Assche <bvanassche@....org>, <quic_asutoshd@...cinc.com>,
        <quic_cang@...cinc.com>, <quic_nguyenb@...cinc.com>,
        <mani@...nel.org>, <stanley.chu@...iatek.com>,
        <adrian.hunter@...el.com>, <beanhuo@...ron.com>,
        <avri.altman@....com>, <junwoo80.lee@...sung.com>,
        <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:TRACING" <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] scsi: ufs: core: Add trace event for MCQ

Hi Bart,

Sure, will fix it.


Best Regards,
Ziqi

On 3/15/2023 2:13 AM, Bart Van Assche wrote:
> On 3/14/23 04:15, Ziqi Chen wrote:
>>       TP_printk(
>> -        "%s: %s: tag: %u, DB: 0x%x, size: %d, IS: %u, LBA: %llu, 
>> opcode: 0x%x (%s), group_id: 0x%x",
>> -        show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name),
>> -        __entry->tag, __entry->doorbell, __entry->transfer_len,
>> -        __entry->intr, __entry->lba, (u32)__entry->opcode,
>> -        str_opcode(__entry->opcode), (u32)__entry->group_id
>> +        "%s: %s: tag: %u, DB: 0x%x, size: %d, IS: %u, LBA: %llu, 
>> opcode: 0x%x (%s), group_id: 0x%x, hwq_id: %d",
>> +         show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name),
>> +         __entry->tag, __entry->doorbell, __entry->transfer_len, 
>> __entry->intr,
>> +         __entry->lba, (u32)__entry->opcode, 
>> str_opcode(__entry->opcode),
>> +         (u32)__entry->group_id, __entry->hwq_id
> 
> The alignment of the TP_printk() arguments looks odd. Please make sure 
> that arguments 2 and later start in the same column as the opening 
> double quote (") instead of one column to the right of that double quote.
> 
> Thanks,
> 
> Bart.
>