linux-kernel - Re: [PATCH] bootconfig: Fix testcase to increase max node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230315165905.4bb2a464b2ffe4fb640cfbdd@kernel.org>
Date:   Wed, 15 Mar 2023 16:59:05 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-trace-kernel@...r.kernel.org,
        Heinz Wiesinger <pprkut@...ckware.com>, andersson@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_rjendra@...cinc.com, quic_saipraka@...cinc.com,
        quic_sibis@...cinc.com
Subject: Re: [PATCH] bootconfig: Fix testcase to increase max node

On Tue, 14 Mar 2023 11:12:13 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 13 Mar 2023 22:56:09 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> 
> > @@ -87,10 +88,16 @@ xfail grep -i "error" $OUTFILE
> >  
> >  echo "Max node number check"
> >  
> > -echo -n > $TEMPCONF
> > -for i in `seq 1 1024` ; do
> > -   echo "node$i" >> $TEMPCONF
> 
> Do you need this extra file?
> 
> > -done
> > +cat > $AWKFILE << EOF
> > +BEGIN {
> > +  for (i = 0; i < 26; i += 1)
> > +      printf("%c\n", 65 + i % 26)
> > +  for (i = 26; i < 8192; i += 1)
> > +      printf("%c%c%c\n", 65 + i % 26, 65 + (i / 26) % 26, 65 + (i / 26 / 26))
> > +}
> > +EOF
> > +awk -f "$AWKFILE" > $TEMPCONF
> 
> Couldn't the above just be:
> 
> awk '
> 	BEGIN {
> 		for (i = 0; i < 26; i += 1)
> 			printf("%c\n", 65 + i % 26)
> 		for (i = 26; i < 8192; i += 1)
> 			printf("%c%c%c\n", 65 + i % 26, 65 + (i / 26) % 26, 65 + (i / 26 / 26))
> 	}
> ' > $TEMPCONF
> 
> and not need the extra file?

Indeed. Let me update this.

Thank you!

> 
> -- Steve
> 
> 
> >  xpass $BOOTCONF -a $TEMPCONF $INITRD
> >  
> >  echo "badnode" >> $TEMPCONF
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>