linux-kernel - Re: [PATCH v9 5/5] usb: gadget: f_ecm: Add suspend/resume and remote wakeup support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230315012857.rzfrad3n2pbmjvwb@synopsys.com>
Date:   Wed, 15 Mar 2023 01:29:05 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Elson Roy Serrao <quic_eserrao@...cinc.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "quic_wcheng@...cinc.com" <quic_wcheng@...cinc.com>,
        "quic_jackp@...cinc.com" <quic_jackp@...cinc.com>
Subject: Re: [PATCH v9 5/5] usb: gadget: f_ecm: Add suspend/resume and remote
 wakeup support

On Tue, Mar 14, 2023, Elson Roy Serrao wrote:
> When host sends a suspend notification to the device, handle
> the suspend callbacks in the function driver. Enhanced super
> speed devices can support function suspend feature to put the
> function in suspend state. Handle function suspend callback.
> 
> Depending on the remote wakeup capability the device can either
> trigger a remote wakeup or wait for the host initiated resume to
> start data transfer again.
> 
> Signed-off-by: Elson Roy Serrao <quic_eserrao@...cinc.com>
> ---
>  drivers/usb/gadget/function/f_ecm.c   | 76 +++++++++++++++++++++++++++++++++++
>  drivers/usb/gadget/function/u_ether.c | 63 +++++++++++++++++++++++++++++
>  drivers/usb/gadget/function/u_ether.h |  4 ++
>  3 files changed, 143 insertions(+)
> 
> diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/function/f_ecm.c
> index a7ab30e..a822e17 100644
> --- a/drivers/usb/gadget/function/f_ecm.c
> +++ b/drivers/usb/gadget/function/f_ecm.c
> @@ -633,6 +633,8 @@ static void ecm_disable(struct usb_function *f)
>  
>  	usb_ep_disable(ecm->notify);
>  	ecm->notify->desc = NULL;
> +	f->func_suspended = false;
> +	f->func_wakeup_armed = false;
>  }
>  
>  /*-------------------------------------------------------------------------*/
> @@ -885,6 +887,76 @@ static struct usb_function_instance *ecm_alloc_inst(void)
>  	return &opts->func_inst;
>  }
>  
> +static void ecm_suspend(struct usb_function *f)
> +{
> +	struct f_ecm *ecm = func_to_ecm(f);
> +	struct usb_composite_dev *cdev = ecm->port.func.config->cdev;
> +
> +	if (f->func_suspended) {
> +		DBG(cdev, "Function already suspended\n");
> +		return;
> +	}
> +
> +	DBG(cdev, "ECM Suspend\n");
> +
> +	gether_suspend(&ecm->port);
> +}
> +
> +static void ecm_resume(struct usb_function *f)
> +{
> +	struct f_ecm *ecm = func_to_ecm(f);
> +	struct usb_composite_dev *cdev = ecm->port.func.config->cdev;
> +
> +	/*
> +	 * If the function is in USB3 Function Suspend state, resume is
> +	 * canceled. In this case resume is done by a Function Resume request.
> +	 */
> +	if (f->func_suspended)
> +		return;
> +
> +	DBG(cdev, "ECM Resume\n");
> +
> +	gether_resume(&ecm->port);
> +}
> +
> +static int ecm_get_status(struct usb_function *f)
> +{
> +	struct usb_configuration *c = f->config;
> +
> +	if (USB_CONFIG_ATT_WAKEUP & c->bmAttributes) {
> +		return (f->func_wakeup_armed ? USB_INTRF_STAT_FUNC_RW : 0) |
> +			USB_INTRF_STAT_FUNC_RW_CAP;
> +	}
> +
> +	return USB_INTRF_STAT_FUNC_RW_CAP;

The function shouldn't be remote wake capable if the configuration
doesn't support remote wake.

> +}
> +
> +static int ecm_func_suspend(struct usb_function *f, u8 options)
> +{
> +	struct usb_configuration *c = f->config;
> +
> +	DBG(c->cdev, "func susp %u cmd\n", options);
> +
> +	if (USB_CONFIG_ATT_WAKEUP & c->bmAttributes) {
> +		f->func_wakeup_armed = !!(options &
> +					 (USB_INTRF_FUNC_SUSPEND_RW >> 8));
> +	}

Can we return negative error if we don't support the request as
suggested?

Thanks,
Thinh

> +
> +	if (options & (USB_INTRF_FUNC_SUSPEND_LP >> 8)) {
> +		if (!f->func_suspended) {
> +			ecm_suspend(f);
> +			f->func_suspended = true;
> +		}
> +	} else {
> +		if (f->func_suspended) {
> +			f->func_suspended = false;
> +			ecm_resume(f);
> +		}
> +	}
> +
> +	return 0;
> +}
> +