linux-kernel - Re: [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFGrd9pa3c3eZcuGg7AmHL8kOAkyx96hwjwnMuO-G9BR1ORJ_w@mail.gmail.com>
Date:   Wed, 15 Mar 2023 10:35:57 +0100
From:   Alexandre Mergnat <amergnat@...libre.com>
To:     Chun-Kuang Hu <chunkuang.hu@...nel.org>
Cc:     Daniel Vetter <daniel@...ll.ch>, CK Hu <ck.hu@...iatek.com>,
        Jitao Shi <jitao.shi@...iatek.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Sam Ravnborg <sam@...nborg.org>,
        Rob Herring <robh+dt@...nel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        David Airlie <airlied@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Xinlei Lee <xinlei.lee@...iatek.com>,
        Guillaume La Roque <glaroque@...libre.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        dri-devel@...ts.freedesktop.org,
        Fabien Parent <fparent@...libre.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock

Le lun. 13 mars 2023 à 16:21, Chun-Kuang Hu <chunkuang.hu@...nel.org> a écrit :
>
> >
> > +       dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
>
> For MT8365, DPI clock is not optional, so make sure that MT8365 DPI
> should have this clock.

This should be check and notified at build time thanks to the
device-tree binding. Do you prefer this?:
#IF MT8365_SOC
    dpi->dpi_clk = devm_clk_get(dev, "dpi");

Regards,
Alex