linux-kernel - Re: [PATCH] wifi: ath12k: Add missing unwind goto in ath12k_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167887550837.27926.11659991726085359589.kvalo@kernel.org>
Date:   Wed, 15 Mar 2023 10:18:33 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc:     unlisted-recipients:; (no To-header on input) error27@...il.com,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        P Praneesh <quic_ppranees@...cinc.com>,
        Karthikeyan Periyasamy <quic_periyasa@...cinc.com>,
        Jeff Johnson <quic_jjohnson@...cinc.com>,
        Bhagavathi Perumal S <quic_bperumal@...cinc.com>,
        Wen Gong <quic_wgong@...cinc.com>, ath12k@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: ath12k: Add missing unwind goto in
 ath12k_pci_probe()

Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com> wrote:

> Smatch Warns:
>         drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
>         warn: missing unwind goto?
> 
> Store the error value in ret and use correct label with a goto.
> 
> Only Compile tested, found with Smatch.
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
> Suggested-by: Dan Carpenter <error27@...il.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

488d9a484f96 wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230307104706.240119-1-harshit.m.mogalapalli@oracle.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches