linux-kernel - Re: [PATCH] io_uring: rsrc: Optimize return value variable 'ret'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <516dc8a8-ea4e-2294-3776-31a2625910b5@kernel.dk>
Date:   Tue, 14 Mar 2023 19:56:41 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Li zeming <zeming@...china.com>, asml.silence@...il.com
Cc:     io-uring@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] io_uring: rsrc: Optimize return value variable 'ret'

On 3/16/23 12:13 PM, Li zeming wrote:
> The function returns here and returns ret directly. It may look better.

I think it'd be better to just initialize 'ret' to 0 instead.

-- 
Jens Axboe