linux-kernel - Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2cf4eb5fc984aec8a21adfc440b511e@akkea.ca>
Date:   Wed, 15 Mar 2023 05:30:34 -0700
From:   Angus Ainslie <angus@...ea.ca>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Martin Kepplinger <martin.kepplinger@...i.sm>, robh@...nel.org,
        krzysztof.kozlowski@...aro.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, kernel@...i.sm,
        linux-imx@....com, devicetree@...r.kernel.org,
        phone-devel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
Subject: Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove
 dis_u3_susphy_quirk from usb_dwc3_0

Hi Shawn,

On 2023-03-14 00:28, Shawn Guo wrote:
> On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote:
>> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
>> 
>> This reduces power consumption in system suspend by about 10%.
> 
> Is there any other impact than this nice power gain?  Otherwise,
> I would wonder why the quirk was enabled in the first place.
> 

This comes from the early days of board bring-up and IIRC it seemed to 
stabilize flashing using the mfgtools over USB. Whatever gremlin was in 
those early boards is long gone and this is no longer needed.

Cheers
Angus

> Shawn
> 
>> 
>> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi 
>> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> index 0b4b49fa1392a..f557632f574fa 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> @@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
>>  	#address-cells = <1>;
>>  	#size-cells = <0>;
>>  	dr_mode = "otg";
>> -	snps,dis_u3_susphy_quirk;
>>  	usb-role-switch;
>>  	status = "okay";
>> 
>> --
>> 2.30.2
>>