linux-kernel - Re: [PATCH v2 2/7] soc: qcom: icc-bwmon: Handle global registers correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c441aca-3676-60bd-9303-230c1410eb41@linaro.org>
Date:   Wed, 15 Mar 2023 14:15:36 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/7] soc: qcom: icc-bwmon: Handle global registers
 correctly

On 15/03/2023 11:13, Konrad Dybcio wrote:
>>>  }
>>>  
>>>  static int bwmon_probe(struct platform_device *pdev)
>>> @@ -645,6 +816,21 @@ static const struct icc_bwmon_data msm8998_bwmon_data = {
>>>  	.quirks = BWMON_HAS_GLOBAL_IRQ,
>>>  	.regmap_fields = msm8998_bwmon_reg_fields,
>>>  	.regmap_cfg = &msm8998_bwmon_regmap_cfg,
>>> +	.global_regmap_fields = msm8998_bwmon_global_reg_fields,
>>> +	.global_regmap_cfg = &msm8998_bwmon_global_regmap_cfg,
>>> +};
>>> +
>>> +static const struct icc_bwmon_data sdm845_ddr_bwmon_data = {
>>
>> The name "ddr" is here (and other places) confusing. This is not the DDR
>> bwmon.
> I suppose cpu_bwmon could make more sense?

Yes, we keep calling it CPU.

Best regards,
Krzysztof