linux-kernel - Re: [PATCH v1] hwmon: drivetemp: support to be a platform driver for thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6efbd9f-27ef-7367-5b8c-9844c21a476b@kernel.org>
Date:   Wed, 15 Mar 2023 15:06:33 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Phinex Hung <phinex@...ltek.com>,
        "jdelvare@...e.com" <jdelvare@...e.com>
Cc:     "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] hwmon: drivetemp: support to be a platform driver for
 thermal_of

On 15/03/2023 15:02, Phinex Hung wrote:
> 
> 
> On 15/03/2023 21:11, "Krzysztof Kozlowski" <krzk@...nel.org <mailto:krzk@...nel.org>> wrote:
> 
> Hi Krzysztof,
> 
> Thanks for your comment.
> 
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC. It might happen, that command when run on an older
>> kernel, gives you outdated entries. Therefore please be sure you base
>> your patches on recent Linux kernel.
> 
> I am working on git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> 
> For master branch.
> 
> Is there any updated git repo that I should rebase my patch?

The mainline master. But even on that kernel you would get different
people to CC, so you did not run the command to get proper addresses.

> 
>> No such vendor prefix. Are you sure you are describing real hardware?
>> Also device specific part looks too generic. What device is it exactly?
> 
> It's a generic patch, just want to support thermal zone using a simple device tree.
> Any SoC with SCSI interface and attached hard drives can benefit this change.

Devicetree describes hardware, not generic patches. Please be more specific.

> 
> Normally a THERMAL_OF require a platform device to add a thermal zone.

Whatever problem is (or is not) with THERMAL_OF does not really matter
to bindings.

> 
> Original drivetemp.c works quite well as a hwmon device, but no thermal zone support.
> 
> My patch just extend its capability to support a simple thermal zone created with this hwmon.

I understand. Still it is not describing any hardware. In all your
statements above you did not reference any specific devices or hardware
at all.

> This is bind to any specific vendor, just to provide an easy way to handle cooling when hard drives' temperature gets high.

Then either you need something more specific to hardware or Devicetree
is not the place to put it.


Best regards,
Krzysztof