linux-kernel - Re: [PATCH 4/5] arm64: dts: rockchip: fix gmac support for NanoPi R5S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOP2_Tii7auK7rHrFF1FT76LnC5coBfhZtGaEpk6Nd=az0UQVg@mail.gmail.com>
Date:   Thu, 16 Mar 2023 22:47:53 +0800
From:   Tianling Shen <cnsztl@...il.com>
To:     Jonas Karlman <jonas@...boo.se>
Cc:     Vasily Khoruzhick <anarsoul@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Peter Geis <pgwipeout@...il.com>, Andy Yan <andyshrk@....com>,
        Brian Norris <briannorris@...omium.org>,
        Chris Morgan <macromorgan@...mail.com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Andrew Lunn <andrew@...n.ch>,
        Michael Riesch <michael.riesch@...fvision.net>,
        Maya Matuszczyk <maccraft123mc@...il.com>,
        Andrew Powers-Holmes <aholmes@...om.net>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] arm64: dts: rockchip: fix gmac support for NanoPi R5S

Hi,

On Thu, Mar 16, 2023 at 4:46 PM Tianling Shen <cnsztl@...il.com> wrote:
>
> Hi Jonas,
>
> On Thu, Mar 16, 2023 at 3:37 PM Jonas Karlman <jonas@...boo.se> wrote:
> >

[...]

> >
> > Generic ethernet phy driver is not resetting the phy in the same way
> > that snsp,reset-gpio does, please see top two commits at [1].
> >
> > I have been meaning to send that out as an RFC but I got stuck in a
> > u-boot rabbit hole, and I also do not know what the correct way to fix
> > this would be, so I played with both device tree and code changes.
> > Will prioritize this and send out a RFC later today.
> >
> > [1] https://github.com/Kwiboo/linux-rockchip/commits/rk3568-eth-phy-reset
>
> Thanks for the hint! I will test your patches tonight.

I'm currently playing your patches at
https://github.com/1715173329/imoutowrt/commits/master-rockchip-mdio

I applied commit 8597fcfa0c5c792dabb44a2db7b283c56c99ec6a to NanoPi
R5S, it worked perfectly.

However, with commit c338ed260bfd87277c41aa0290f1f2aad8d629b1 + moving
reset properties into the phy node,
the driver still failed to lookup phy. I'm not sure if I missed /
misunderstood anything.

Thanks,
Tianling.

[...]