linux-kernel - Re: [PATCH v13 005/113] KVM: TDX: Add placeholders for TDX VM/vcpu structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230316154118.GC259042@ls.amr.corp.intel.com>
Date:   Thu, 16 Mar 2023 08:41:18 -0700
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     "Huang, Kai" <kai.huang@...el.com>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "zhi.wang.linux@...il.com" <zhi.wang.linux@...il.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "Shahar, Sagi" <sagis@...gle.com>,
        "Aktas, Erdem" <erdemaktas@...gle.com>,
        "isaku.yamahata@...il.com" <isaku.yamahata@...il.com>,
        "dmatlack@...gle.com" <dmatlack@...gle.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>
Subject: Re: [PATCH v13 005/113] KVM: TDX: Add placeholders for TDX VM/vcpu
 structure

On Wed, Mar 15, 2023 at 10:42:09AM +0000,
"Huang, Kai" <kai.huang@...el.com> wrote:

> On Sun, 2023-03-12 at 10:55 -0700, isaku.yamahata@...el.com wrote:
> > +
> > +static inline bool is_td(struct kvm *kvm)
> > +{
> > +	return kvm->arch.vm_type == KVM_X86_PROTECTED_VM;
> > +}
> > +
> 
> KVM_X86_PROTECTED_VM is defined in the next patch, which means this patch cannot
> compile.
> 
> Also, why KVM_X86_PROTECTED_VM == TDX VM?

This part needs to be resolved.
Use KVM_X86_PROTECTED_VM as TDX VM or new type KVM_X86_TDX_VM or other way
to specify VM type.
Given pKVM is coming, dedicated VM type seems better.  I'll switch it to
KVM_X86_TDX_VM next respin.
-- 
Isaku Yamahata <isaku.yamahata@...il.com>