linux-kernel - Re: [PATCH 01/18] mfd: da903x: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230316154237.GJ9667@google.com>
Date:   Thu, 16 Mar 2023 15:42:37 +0000
From:   Lee Jones <lee@...nel.org>
To:     Nick Alcock <nick.alcock@...cle.com>
Cc:     Luis Chamberlain <mcgrof@...nel.org>,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH 01/18] mfd: da903x: remove MODULE_LICENSE in non-modules

On Wed, 08 Mar 2023, Nick Alcock wrote:

> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Support Opensource <support.opensource@...semi.com>
> Cc: Lee Jones <lee@...nel.org>
> ---
>  drivers/mfd/da903x.c | 1 -
>  1 file changed, 1 deletion(-)

All applied, thanks

--
Lee Jones [李琼斯]