[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b16a31ab-907c-1478-3a07-44d588318768@arm.com>
Date: Thu, 16 Mar 2023 16:47:20 +0000
From: Suzuki K Poulose <suzuki.poulose@....com>
To: James Clark <james.clark@....com>, coresight@...ts.linaro.org
Cc: Mathieu Poirier <mathieu.poirier@...aro.org>,
Mike Leach <mike.leach@...aro.org>,
Leo Yan <leo.yan@...aro.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/9] coresight: Use enum type for cs_mode wherever
possible
On 10/03/2023 16:06, James Clark wrote:
> mode is stored as a local_t, but it is also passed around a lot as a
> plain u32, so use the correct type wherever local_t isn't currently
> used. This helps a little bit with readability.
>
> Signed-off-by: James Clark <james.clark@....com>
> ---
> drivers/hwtracing/coresight/coresight-core.c | 7 ++++---
> drivers/hwtracing/coresight/coresight-etb10.c | 3 ++-
> drivers/hwtracing/coresight/coresight-etm3x-core.c | 6 +++---
> drivers/hwtracing/coresight/coresight-etm4x-core.c | 6 +++---
> drivers/hwtracing/coresight/coresight-priv.h | 9 ++-------
> drivers/hwtracing/coresight/coresight-stm.c | 6 +++---
> drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +-
> drivers/hwtracing/coresight/coresight-tmc-etr.c | 7 +++----
> drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++--
> drivers/hwtracing/coresight/coresight-tpiu.c | 3 ++-
> drivers/hwtracing/coresight/coresight-trbe.c | 3 ++-
> drivers/hwtracing/coresight/ultrasoc-smb.c | 3 ++-
> drivers/hwtracing/coresight/ultrasoc-smb.h | 2 +-
> include/linux/coresight.h | 13 ++++++++++---
> 14 files changed, 40 insertions(+), 34 deletions(-)
>
Looks good to me.
Suzuki
Powered by blists - more mailing lists