linux-kernel - Re: [PATCH] KVM: Add the missing stub function for kvm_dirty_ring_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBNLnp7c1JvDsmHm@google.com>
Date:   Thu, 16 Mar 2023 10:02:22 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        gshan@...hat.com, maz@...nel.org
Subject: Re: [PATCH] KVM: Add the missing stub function for kvm_dirty_ring_check_request()

On Thu, Mar 16, 2023, Shameer Kolothum wrote:
> The stub for !CONFIG_HAVE_KVM_DIRTY_RING case is missing.

No stub is needed.  kvm_dirty_ring_check_request() isn't called from common code,
and should not (and isn't unless I'm missing something) be called from arch code
unless CONFIG_HAVE_KVM_DIRTY_RING=y.

x86 and arm64 are the only users, and they both select HAVE_KVM_DIRTY_RING
unconditionally when KVM is enabled.