| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202303170223.V0xQhs1V-lkp@intel.com>
Date: Fri, 17 Mar 2023 03:03:04 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Mickaël Salaün <mic@...ikod.net>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Krzysztof Wilczyński <kw@...ux.com>,
Michael Ellerman <mpe@...erman.id.au>,
Randy Dunlap <rdunlap@...radead.org>,
Arnd Bergmann <arnd@...db.de>,
Niklas Schnelle <schnelle@...ux.ibm.com>,
Bjorn Helgaas <helgaas@...nel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Pali Rohár <pali@...nel.org>,
"Maciej W. Rozycki" <macro@...am.me.uk>,
Juergen Gross <jgross@...e.com>,
Dominik Brodowski <linux@...inikbrodowski.net>,
linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org,
sparclinux@...r.kernel.org, linux-pci@...r.kernel.org,
xen-devel@...ts.xenproject.org, linux-acpi@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Miguel Ojeda <ojeda@...nel.org>,
Richard Henderson <richard.henderson@...aro.org>,
Ivan Kokshaysky <ink@...assic.park.msu.ru>,
Matt Turner <mattst88@...il.com>,
Russell King <linux@...linux.org.uk>,
Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource()
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus powerpc/next powerpc/fixes linus/master v6.3-rc2 next-20230316]
[cannot apply to soc/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/PCI-Introduce-pci_dev_for_each_resource/20230315-032821
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20230314192634.63531-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource()
config: powerpc-randconfig-r032-20230312 (https://download.01.org/0day-ci/archive/20230317/202303170223.V0xQhs1V-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/85cdf4746b716f7b6c14d7dc5cd907c3c2a1fb0c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/PCI-Introduce-pci_dev_for_each_resource/20230315-032821
git checkout 85cdf4746b716f7b6c14d7dc5cd907c3c2a1fb0c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303170223.V0xQhs1V-lkp@intel.com/
All errors (new ones prefixed by >>):
>> arch/powerpc/platforms/52xx/mpc52xx_pci.c:331:6: error: unused variable 'i' [-Werror,-Wunused-variable]
int i;
^
1 error generated.
vim +/i +331 arch/powerpc/platforms/52xx/mpc52xx_pci.c
f42963f8646540 Grant Likely 2006-12-12 326
f42963f8646540 Grant Likely 2006-12-12 327 static void
f42963f8646540 Grant Likely 2006-12-12 328 mpc52xx_pci_fixup_resources(struct pci_dev *dev)
f42963f8646540 Grant Likely 2006-12-12 329 {
85cdf4746b716f Mika Westerberg 2023-03-14 330 struct resource *res;
f42963f8646540 Grant Likely 2006-12-12 @331 int i;
f42963f8646540 Grant Likely 2006-12-12 332
59510820fff76f Randy Dunlap 2021-04-28 333 pr_debug("%s() %.4x:%.4x\n", __func__, dev->vendor, dev->device);
f42963f8646540 Grant Likely 2006-12-12 334
f42963f8646540 Grant Likely 2006-12-12 335 /* We don't rely on boot loader for PCI and resets all
f42963f8646540 Grant Likely 2006-12-12 336 devices */
85cdf4746b716f Mika Westerberg 2023-03-14 337 pci_dev_for_each_resource_p(dev, res) {
f42963f8646540 Grant Likely 2006-12-12 338 if (res->end > res->start) { /* Only valid resources */
f42963f8646540 Grant Likely 2006-12-12 339 res->end -= res->start;
f42963f8646540 Grant Likely 2006-12-12 340 res->start = 0;
f42963f8646540 Grant Likely 2006-12-12 341 res->flags |= IORESOURCE_UNSET;
f42963f8646540 Grant Likely 2006-12-12 342 }
f42963f8646540 Grant Likely 2006-12-12 343 }
f42963f8646540 Grant Likely 2006-12-12 344
f42963f8646540 Grant Likely 2006-12-12 345 /* The PCI Host bridge of MPC52xx has a prefetch memory resource
f42963f8646540 Grant Likely 2006-12-12 346 fixed to 1Gb. Doesn't fit in the resource system so we remove it */
f42963f8646540 Grant Likely 2006-12-12 347 if ( (dev->vendor == PCI_VENDOR_ID_MOTOROLA) &&
f42963f8646540 Grant Likely 2006-12-12 348 ( dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200
f42963f8646540 Grant Likely 2006-12-12 349 || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B) ) {
f42963f8646540 Grant Likely 2006-12-12 350 struct resource *res = &dev->resource[1];
f42963f8646540 Grant Likely 2006-12-12 351 res->start = res->end = res->flags = 0;
f42963f8646540 Grant Likely 2006-12-12 352 }
f42963f8646540 Grant Likely 2006-12-12 353 }
f42963f8646540 Grant Likely 2006-12-12 354
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists