linux-kernel - Re: [PATCH net v2 2/2] sh_eth: avoid PHY being resumed when interface is not up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4985c895-636d-9707-0acb-5334ae74e906@omp.ru>
Date:   Thu, 16 Mar 2023 22:58:41 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        <netdev@...r.kernel.org>
CC:     <linux-renesas-soc@...r.kernel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Michal Kubiak <michal.kubiak@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Florian Fainelli <f.fainelli@...il.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2 2/2] sh_eth: avoid PHY being resumed when interface
 is not up

On 3/15/23 10:41 AM, Wolfram Sang wrote:

> SH_ETH doesn't need mdiobus suspend/resume, that's why it sets
> 'mac_managed_pm'. However, setting it needs to be moved from init to
> probe, so mdiobus PM functions will really never be called (e.g. when
> the interface is not up yet during suspend/resume).
> 
> Fixes: 6a1dbfefdae4 ("net: sh_eth: Fix PHY state warning splat during system resume")
> Suggested-by: Heiner Kallweit <hkallweit1@...il.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>

[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

MBR, Sergey