linux-kernel - Re: [PATCH net v2 1/2] ravb: avoid PHY being resumed when interface is not up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69230fab-349f-0666-de67-59b11001094d@gmail.com>
Date:   Thu, 16 Mar 2023 13:07:39 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Heiner Kallweit <hkallweit1@...il.com>,
        Michal Kubiak <michal.kubiak@...el.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2 1/2] ravb: avoid PHY being resumed when interface
 is not up

On 3/16/23 13:06, Wolfram Sang wrote:
> 
>> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Thanks!
> 
>> This is a pattern that a lot of drivers have, for better or for worse, it
>> would be neat if we couldcome up with a common helper that could work mostly
>> with OF configurations, what do you think?
> 
> I am not so experienced in this subsystem, so I only could identify 4
> drivers which need this pattern, with one not using OF. So, while I
> trust you with a helper being useful, I'd like to pass this task to
> someone more experienced here.

That seems entirely fair, I have one such platform, so may come up with 
a helper after I debug this other issue I am looking at :)
-- 
Florian