linux-kernel - Re: [PATCH] kunit: Use gfp in kunit_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOSn9n+b-oD72yPiYXW8=ZnPt5xcgtAwWqgSah4hTh1mg=w@mail.gmail.com>
Date:   Thu, 16 Mar 2023 11:36:21 +0800
From:   David Gow <davidgow@...gle.com>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        kunit-dev@...glegroups.com
Subject: Re: [PATCH] kunit: Use gfp in kunit_alloc_resource() kernel-doc

On Thu, 16 Mar 2023 at 07:39, Stephen Boyd <sboyd@...nel.org> wrote:
>
> Copy/pasting the code from the kernel-doc here doesn't compile because
> kunit_alloc_resource() takes a gfp flags argument. Pass the gfp
> argument from the caller to complete the example.
>
> Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> ---

Nice catch!

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

>  include/kunit/resource.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/resource.h b/include/kunit/resource.h
> index cf6fb8f2ac1b..c0d88b318e90 100644
> --- a/include/kunit/resource.h
> +++ b/include/kunit/resource.h
> @@ -72,7 +72,7 @@ typedef void (*kunit_resource_free_t)(struct kunit_resource *);
>   *             params.gfp = gfp;
>   *
>   *             return kunit_alloc_resource(test, kunit_kmalloc_init,
> - *                     kunit_kmalloc_free, &params);
> + *                     kunit_kmalloc_free, gfp, &params);
>   *     }
>   *
>   * Resources can also be named, with lookup/removal done on a name
>
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)