linux-kernel - Re: [PATCH net] vmxnet3: use gro callback when UPT is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230315211329.1c7b3566@kernel.org>
Date:   Wed, 15 Mar 2023 21:13:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ronak Doshi <doshir@...are.com>
Cc:     Yunsheng Lin <linyunsheng@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Pv-drivers <Pv-drivers@...are.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Guolin Yang <gyang@...are.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] vmxnet3: use gro callback when UPT is enabled

On Thu, 16 Mar 2023 04:03:52 +0000 Ronak Doshi wrote:
> > Calling netif_receive_skb() with NETIF_F_GRO bit set in netdev->features will cause
> > confusion for user, IMHO.  
> As long as LRO is enabled and performed by ESXi (which it will do), I don’t think user cares for GRO.
> Even if we use napi_gro_receive() for such case, it degrades the performance as unnecessary cycles
> are spend on an already LRO'ed packet.

Can you provide some numbers to illustrate what the slow down is?