linux-kernel - Re: [PATCH v2] soundwire: bandwidth allocation: Use hweight32() to calculate set bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2023 11:32:47 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc:     yung-chuan.liao@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, sanyog.r.kale@...el.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH v2] soundwire: bandwidth allocation: Use hweight32() to
 calculate set bits

On 15-03-23, 14:50, Richard Fitzgerald wrote:
> Replace the call to sdw_ch_mask_to_ch() with a call to hweight32().
> 
> sdw_ch_mask_to_ch() is counting the number of set bits. The hweight()
> family of functions already do this, and they have an advantage of
> using a bit-counting instruction if it is available on the target CPU.
> This also fixes a potential infinite loop bug in the implementation of
> sdw_ch_mask_to_ch().

Applied, thanks

-- 
~Vinod