linux-kernel - Re: next: arm-32bit: build errors: kernel/module/internal.h:252:56: error: expected ';', ',' or ')' before 'const'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8e4cc40-f764-0a99-be50-015d4000adfd@redhat.com>
Date:   Thu, 16 Mar 2023 08:53:41 +0100
From:   Viktor Malik <vmalik@...hat.com>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        lkft-triage@...ts.linaro.org, bpf <bpf@...r.kernel.org>,
        linux-mips@...r.kernel.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Arnd Bergmann <arnd@...db.de>, Jiri Olsa <jolsa@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>
Subject: Re: next: arm-32bit: build errors: kernel/module/internal.h:252:56:
 error: expected ';', ',' or ')' before 'const'

On 3/16/23 08:14, Naresh Kamboju wrote:
> Results from Linaro’s test farm.
> Following mips and arm builds failed.
> 
> Regressions found on mips:
>   - build/gcc-12-ath79_defconfig
>   - build/gcc-8-ath79_defconfig
> 
> Regressions found on arm:
>   - build/gcc-8-omap1_defconfig
>   - build/gcc-12-omap1_defconfig
>   - build/clang-nightly-omap1_defconfig
>   - build/clang-16-omap1_defconfig
> 
> 
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> 
> Build log:
> ------------
> 
> In file included from kernel/module/main.c:59:
> kernel/module/internal.h:252:56: error: expected ';', ',' or ')' before 'const'
>    252 |                                                        const char *name)
>        |                                                        ^~~~~
> make[4]: *** [scripts/Makefile.build:252: kernel/module/main.o] Error 1
> In file included from kernel/module/strict_rwx.c:12:
> kernel/module/internal.h:252:56: error: expected ';', ',' or ')' before 'const'
>    252 |                                                        const char *name)
>        |                                                        ^~~~~
> make[4]: *** [scripts/Makefile.build:252: kernel/module/strict_rwx.o] Error 1
> In file included from kernel/module/tree_lookup.c:11:
> kernel/module/internal.h:252:56: error: expected ';', ',' or ')' before 'const'
>    252 |                                                        const char *name)
>        |                                                        ^~~~~
> make[4]: *** [scripts/Makefile.build:252: kernel/module/tree_lookup.o] Error 1
> In file included from kernel/module/procfs.c:13:
> kernel/module/internal.h:252:56: error: expected ';', ',' or ')' before 'const'
>    252 |                                                        const char *name)
>        |                                                        ^~~~~
> make[4]: *** [scripts/Makefile.build:252: kernel/module/procfs.o] Error 1
> In file included from kernel/module/sysfs.c:15:
> kernel/module/internal.h:252:56: error: expected ';', ',' or ')' before 'const'
>    252 |                                                        const char *name)
>        |                                                        ^~~~~
> make[4]: *** [scripts/Makefile.build:252: kernel/module/sysfs.o] Error 1
> 
> 
> build log:
>   - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230316/testrun/15632981/suite/build/test/gcc-12-omap1_defconfig/log
>   - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230316/testrun/15632981/suite/build/test/gcc-12-omap1_defconfig/details/
> 

Hi,

this was fixed by Alexei by force-pushing bpf-next [1] but it seems that 
linux-next has managed to pull bpf-next in the meantime. I'm not sure 
what is the best way to fix this in linux-next, let me know if I should 
send a patch.

I apologize for the trouble.
Viktor

[1] 
https://lore.kernel.org/bpf/6c8f828c-3995-a9b0-3bdd-37724e96a4ce@redhat.com/T/#m44dc53d16524fa818d6a9397487107805e5f0713

> 
> --
> Linaro LKFT
> https://lkft.linaro.org
>