linux-kernel - Re: [PATCH] Documentation: submitting-patches: Disqualify style fixes from Fixes: tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBLSrXrxrV4dRjak@kroah.com>
Date:   Thu, 16 Mar 2023 09:26:21 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Bagas Sanjaya <bagasdotme@...il.com>,
        Linux Documentation <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Outreachy <outreachy@...ts.linux.dev>,
        Jonathan Corbet <corbet@....net>,
        Thorsten Leemhuis <linux@...mhuis.info>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Akira Yokosawa <akiyks@...il.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Kloudifold <cloudifold.3125@...il.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: [PATCH] Documentation: submitting-patches: Disqualify style
 fixes from Fixes: tag

On Thu, Mar 16, 2023 at 09:23:28AM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2023 09:20, Bagas Sanjaya wrote:
> > An interpretation of submitting-patches.rst regarding Fixes: tag
> > interprets that the tag can be attributed to all kinds of issues
> > (including coding style ones). However, from the discussion on Outreachy
> > mailing list [1], Greg noted that the tag should not be meant for
> > patches that fix coding style issues.
> > 
> > Clarify the position on the doc.
> > 
> > Link: https://lore.kernel.org/outreachy/ZBFPnZbvdI46Ah6r@kroah.com/ [1]
> > Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> > ---
> >  Documentation/process/submitting-patches.rst | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> > index 69ce64e03c70f8..564418e42ffc01 100644
> > --- a/Documentation/process/submitting-patches.rst
> > +++ b/Documentation/process/submitting-patches.rst
> > @@ -568,6 +568,9 @@ process nor the requirement to Cc: stable@...r.kernel.org on all stable
> >  patch candidates. For more information, please read
> >  Documentation/process/stable-kernel-rules.rst.
> >  
> > +Note: Fixes: tag is appropriate only for real issues (e.g. reported bugs
> > +or compiler warnings). Coding style fixes should not bear this tag.
> 
> I think it is pretty clear already. The doc says:
> "If your patch fixes a bug in a specific commit,"
> 
> and you are now repeating this.
> 
> Coding style is not a bug, but that's obvious.

I agree, let's not make this file even longer than it is if at all
possible.

thanks,

greg k-h