linux-kernel - Re: [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2023 14:17:05 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, <andersson@...nel.org>
CC:     <mathieu.poirier@...aro.org>, <matthias.bgg@...il.com>,
        <angelogioacchino.delregno@...labora.com>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment



On 3/16/2023 2:10 PM, Yang Li wrote:
> Fixs the function name in kernel-doc comments to clear the below

nit: Fix

> warning:
> 
> drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/remoteproc/mtk_scp_ipi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c
> index fc55df649b40..9c7c17b9d181 100644
> --- a/drivers/remoteproc/mtk_scp_ipi.c
> +++ b/drivers/remoteproc/mtk_scp_ipi.c
> @@ -125,7 +125,7 @@ void scp_ipi_lock(struct mtk_scp *scp, u32 id)
>   EXPORT_SYMBOL_GPL(scp_ipi_lock);
>   
>   /**
> - * scp_ipi_lock() - Unlock after operations of an IPI ID
> + * scp_ipi_unlock() - Unlock after operations of an IPI ID
>    *
>    * @scp:	mtk_scp structure
>    * @id:		IPI ID

Otherwise LGTM.

Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-- Mukesh