linux-kernel - Re: [PATCH v1 1/3] rust: macros: add `quote!` macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <rwLWkKoa4chEtf0rqg_7vYX5cTjKz4etynZ-i5wG_JCvF_O-6vf2I2cc205cZHFId2DJswFm_5FjpN5-8SYuF-FEdkCxMTPh_R9UCEB5fJA=@protonmail.com>
Date:   Thu, 16 Mar 2023 09:33:59 +0000
From:   y86-dev <y86-dev@...tonmail.com>
To:     Boqun Feng <boqun.feng@...il.com>
Cc:     "ojeda@...nel.org" <ojeda@...nel.org>,
        "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
        "wedsonaf@...il.com" <wedsonaf@...il.com>,
        Gary Guo <gary@...yguo.net>,
        "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
        "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: Re: [PATCH v1 1/3] rust: macros: add `quote!` macro

On Monday, March 13th, 2023 at 16:30, Boqun Feng <boqun.feng@...il.com> wrote:
> On Mon, Mar 13, 2023 at 01:23:18AM +0000, y86-dev wrote:
>
> > From: Gary Guo gary@...yguo.net
> >
> > Add the `quote!` macro for creating `TokenStream`s directly via the
> > given Rust tokens. It also supports repetitions using iterators.
> >
> > It will be used by the pin-init API proc-macros to generate code.
> >
> > Signed-off-by: Gary Guo gary@...yguo.net
> > Signed-off-by: Benno Lossin y86-dev@...tonmail.com
>
>
> Not sure whether I missed any sutble details, but the macros look
> straight-forward. One thing could be improved is having a doc describing
> what `quote!` does, a link to the quote crate will do the trick.
>
> Anyway, the code looks good to me.
>
> Acked-by: Boqun Feng boqun.feng@...il.com
>
>
> Regards,
> Boqun

Sure, will put it in v2!

Regards,
Benno