linux-kernel - Re: [PATCH v6 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7be8db9-0bdd-644d-c7a0-4321041c5028@molgen.mpg.de>
Date:   Thu, 16 Mar 2023 10:58:22 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Steev Klimaszewski <steev@...i.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Sven Peter <sven@...npeter.dev>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        Mark Pearson <markpearson@...ovo.com>,
        Tim Jiang <quic_tjiang@...cinc.com>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v6 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth
 chip wcn6855

Dear Steev,


Thank you for your patch. Some nits.

Am 16.03.23 um 04:47 schrieb Steev Klimaszewski:
> Added regulators,GPIOs and changes required to power on/off wcn6855.

Please add a space after the comma.

> Added support for firmware download for wcn6855.

You might want to use imperative mood (Add …).

How did you test this? What firmware files did you use?

Maybe mention, that the assumption is, that it’s identical to WCN6750?

> Signed-off-by: Steev Klimaszewski <steev@...i.org>
> Reviewed-by: Bjorn Andersson <andersson@...nel.org>
> Tested-by: Bjorn Andersson <andersson@...nel.org>
> ---

[…]


Kind regards,

Paul