linux-kernel - Re: [PATCH v3 05/16] can: m_can: Keep interrupts enabled during peripheral read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBLphKHVYQltkLpb@corigine.com>
Date:   Thu, 16 Mar 2023 11:03:48 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Markus Schneider-Pargmann <msp@...libre.com>
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@...sung.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Vincent MAILHOL <mailhol.vincent@...adoo.fr>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 05/16] can: m_can: Keep interrupts enabled during
 peripheral read

On Wed, Mar 15, 2023 at 12:05:35PM +0100, Markus Schneider-Pargmann wrote:
> Interrupts currently get disabled if the interrupt status shows new
> received data. Non-peripheral chips handle receiving in a worker thread,
> but peripheral chips are handling the receive process in the threaded
> interrupt routine itself without scheduling it for a different worker.
> So there is no need to disable interrupts for peripheral chips.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>