linux-kernel - Re: [PATCH v2 9/9] selftests/resctrl: Correct get_llc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4830705e-212f-6dd1-e8e9-7a35cc886d5@linux.intel.com>
Date:   Thu, 16 Mar 2023 12:21:35 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Reinette Chatre <reinette.chatre@...el.com>
cc:     linux-kselftest@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v2 9/9] selftests/resctrl: Correct get_llc_perf() param
 in function comment

On Wed, 15 Mar 2023, Reinette Chatre wrote:

> Hi Ilpo,
> 
> On 2/15/2023 5:06 AM, Ilpo Järvinen wrote:
> > get_llc_perf() function comment refers to cpu_no parameter that does
> > not exist.
> > 
> > Correct get_llc_perf() the comment to document llc_perf_miss instead.
> 
> "Correct the get_llc_perf() comment"?

Yes. No matter how many times I read my own changelogs through, my mind 
goes to auto-correction mode and I often fail to spot obvious errors such 
as this.

Thanks for reviewing.

-- 
 i.

> This is so minor and I do not think a reason to resubmit whole series.

> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > ---
> 
> Thank you
> 
> Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>
> 
> Reinette
>