linux-kernel - Re: [PATCH -next v2] media: atmel: atmel-isc: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12764b50-8eaf-dd9d-a9ff-d2f1b9d35063@microchip.com>
Date:   Thu, 16 Mar 2023 11:15:35 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <yang.lee@...ux.alibaba.com>, <mchehab@...nel.org>
CC:     <eugen.hristev@...labora.com>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <gregkh@...uxfoundation.org>,
        <linux-media@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next v2] media: atmel: atmel-isc: Use
 devm_platform_ioremap_resource()

On 15.03.2023 02:30, Yang Li wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> According to commit 7945f929f1a7 ("drivers: provide
> devm_platform_ioremap_resource()"), convert platform_get_resource(),
> devm_ioremap_resource() to a single call to use
> devm_platform_ioremap_resource(), as this is exactly what this function
> does.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
> 
> change in v2:
> According to Claudiu's suggestion, make the 'Use' to 'use'in  the commit description.
> 
>  drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 4 +---
>  drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> index ba0614f981a2..eebb336efce7 100644
> --- a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> +++ b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> @@ -389,7 +389,6 @@ static int atmel_isc_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
>         struct isc_device *isc;
> -       struct resource *res;
>         void __iomem *io_base;
>         struct isc_subdev_entity *subdev_entity;
>         int irq;
> @@ -403,8 +402,7 @@ static int atmel_isc_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, isc);
>         isc->dev = dev;
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       io_base = devm_ioremap_resource(dev, res);
> +       io_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(io_base))
>                 return PTR_ERR(io_base);
> 
> diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> index 01ababdfcbd9..beed40fe3f91 100644
> --- a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> +++ b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c
> @@ -378,7 +378,6 @@ static int microchip_xisc_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
>         struct isc_device *isc;
> -       struct resource *res;
>         void __iomem *io_base;
>         struct isc_subdev_entity *subdev_entity;
>         int irq;
> @@ -392,8 +391,7 @@ static int microchip_xisc_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, isc);
>         isc->dev = dev;
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       io_base = devm_ioremap_resource(dev, res);
> +       io_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(io_base))
>                 return PTR_ERR(io_base);
> 
> --
> 2.20.1.7.g153144c
>