linux-kernel - Re: [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2023 10:28:30 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        alexander.deucher@....com
Cc:     Xinhui.Pan@....com, Abaci Robot <abaci@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, daniel@...ll.ch,
        airlied@...il.com, christian.koenig@....com
Subject: Re: [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera
 static

On 3/16/23 05:51, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_dm_mst_types.c, so marks it
> static.
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:211:6: warning: no previous prototype for ‘is_synaptics_cascaded_panamera’.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4548
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

I applied the series, thanks!

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 6378352346c8..994ba426ca66 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -208,7 +208,7 @@ bool needs_dsc_aux_workaround(struct dc_link *link)
>   	return false;
>   }
>   
> -bool is_synaptics_cascaded_panamera(struct dc_link *link, struct drm_dp_mst_port *port)
> +static bool is_synaptics_cascaded_panamera(struct dc_link *link, struct drm_dp_mst_port *port)
>   {
>   	u8 branch_vendor_data[4] = { 0 }; // Vendor data 0x50C ~ 0x50F
>   

-- 
Hamza