linux-kernel - Re: [PATCH 1/5] dmaengine: dw-axi-dmac: Don't set chancnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZBSlvrDmKGjwWBa7@matsya>
Date:   Fri, 17 Mar 2023 23:09:10 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Jisheng Zhang <jszhang@...nel.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Sinan Kaya <okaya@...nel.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/5] dmaengine: dw-axi-dmac: Don't set chancnt

On 14-03-23, 01:02, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it

The dmaengine framework...

> outself is wrong.

s/outself/ourself

Looks this this is needed for all the patches

> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index 4169e1d7d5ca..7f3a60e28e38 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev)
>  	dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask);
>  
>  	/* DMA capabilities */
> -	dw->dma.chancnt = hdata->nr_channels;
>  	dw->dma.max_burst = hdata->axi_rw_burst_len;
>  	dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS;
>  	dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS;
> -- 
> 2.39.2

-- 
~Vinod