linux-kernel - Re: [PATCH] selftests/resctrl: Use correct exit code when tests fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef0ff486-afed-5b3b-34af-0b8a7c5ff5b3@intel.com>
Date:   Fri, 17 Mar 2023 10:49:53 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Peter Newman <peternewman@...gle.com>,
        Fenghua Yu <fenghua.yu@...el.com>
CC:     Shuah Khan <shuah@...nel.org>,
        Shaopeng Tan <tan.shaopeng@...fujitsu.com>,
        <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
        <eranian@...gle.com>
Subject: Re: [PATCH] selftests/resctrl: Use correct exit code when tests fail

Hi Peter,

On 3/9/2023 6:57 AM, Peter Newman wrote:
> Use ksft_finished() after running tests so that resctrl_tests doesn't
> return exit code 0 when tests fail.
> 
> Consequently, report the MBA and MBM tests as skipped when running on
> non-Intel hardware, otherwise resctrl_tests will exit with a failure
> code.
> 
> Signed-off-by: Peter Newman <peternewman@...gle.com>
> ---

Thank you very much.

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette