linux-kernel - Re: [PATCH v2 15/21] dt-bindings: pinctrl: {mediatek,ralink}: fix formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <690e29ee-5e40-5f57-59d7-7c1167852cfb@arinc9.com>
Date:   Fri, 17 Mar 2023 20:51:54 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Sean Wang <sean.wang@...iatek.com>,
        linux-arm-kernel@...ts.infradead.org,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Hui Liu <hui.liu@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        linux-kernel@...r.kernel.org,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Del Regno <angelogioacchino.delregno@...labora.com>,
        erkin.bozoglu@...ont.com, linux-gpio@...r.kernel.org,
        Zhiyong Tao <zhiyong.tao@...iatek.com>,
        Daniel Santos <daniel.santos@...ox.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Rob Herring <robh+dt@...nel.org>,
        Daniel Golle <daniel@...rotopia.org>,
        Andy Teng <andy.teng@...iatek.com>,
        William Dean <williamsukatube@...il.com>,
        devicetree@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sean Wang <sean.wang@...nel.org>,
        linux-mediatek@...ts.infradead.org, linux-mips@...r.kernel.org,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH v2 15/21] dt-bindings: pinctrl: {mediatek,ralink}: fix
 formatting

On 14.03.2023 18:38, Arınç ÜNAL wrote:
> On 14.03.2023 17:10, Rob Herring wrote:
>>
>> On Mon, 13 Mar 2023 23:59:15 +0300, arinc9.unal@...il.com wrote:
>>> From: Arınç ÜNAL <arinc.unal@...nc9.com>
>>>
>>> Change the style of description properties to plain style where 
>>> there's no
>>> need to preserve the line endings, and vice versa.
>>>
>>> Fit the schemas to 80 columns for each line.
>>>
>>> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
>>> Reviewed-by: Rob Herring <robh@...nel.org>
>>> ---
>>>   .../pinctrl/mediatek,mt65xx-pinctrl.yaml      | 22 +++---
>>>   .../pinctrl/mediatek,mt6779-pinctrl.yaml      | 33 +++++----
>>>   .../pinctrl/mediatek,mt6795-pinctrl.yaml      | 33 +++++----
>>>   .../pinctrl/mediatek,mt7620-pinctrl.yaml      |  2 +-
>>>   .../pinctrl/mediatek,mt7621-pinctrl.yaml      |  2 +-
>>>   .../pinctrl/mediatek,mt7622-pinctrl.yaml      | 26 +++----
>>>   .../pinctrl/mediatek,mt7981-pinctrl.yaml      | 33 +++++----
>>>   .../pinctrl/mediatek,mt7986-pinctrl.yaml      | 68 ++++++++---------
>>>   .../pinctrl/mediatek,mt8183-pinctrl.yaml      | 26 ++++---
>>>   .../pinctrl/mediatek,mt8186-pinctrl.yaml      | 47 ++++++------
>>>   .../pinctrl/mediatek,mt8188-pinctrl.yaml      | 74 ++++++++++---------
>>>   .../pinctrl/mediatek,mt8192-pinctrl.yaml      | 47 ++++++------
>>>   .../pinctrl/mediatek,mt8195-pinctrl.yaml      | 41 +++++-----
>>>   .../pinctrl/mediatek,mt8365-pinctrl.yaml      | 28 +++----
>>>   .../pinctrl/ralink,rt2880-pinctrl.yaml        |  2 +-
>>>   .../pinctrl/ralink,rt305x-pinctrl.yaml        |  2 +-
>>>   .../pinctrl/ralink,rt3883-pinctrl.yaml        |  2 +-
>>>   17 files changed, 254 insertions(+), 234 deletions(-)
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>> ./Documentation/devicetree/bindings/pinctrl/mediatek,mt6795-pinctrl.yaml:103:16: [warning] wrong indentation: expected 14 but found 15 (indentation)
>> ./Documentation/devicetree/bindings/pinctrl/mediatek,mt6795-pinctrl.yaml:113:16: [warning] wrong indentation: expected 14 but found 15 (indentation)
>>
>> dtschema/dtc warnings/errors:
>>
>> doc reference errors (make refcheckdocs):
>>
>> See 
>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230313205921.35342-16-arinc.unal@arinc9.com
>>
>> The base for the series is generally the latest rc1. A different 
>> dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your 
>> schema.
> 
> I do see the warning. Looks like the wrong indentation was there before 
> my patch series. I'll address that as well on this patch on v3.
> 
> Will you review the rest of v2?

I guess that's a no. I'll send v3 soon.

Arınç