linux-kernel - Re: [PATCH 12/16] crypto: iaa - Add support for iaa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <472cf360819845616daea229e9884cf9febf06e9.camel@linux.intel.com>
Date:   Fri, 17 Mar 2023 13:28:54 -0500
From:   Tom Zanussi <tom.zanussi@...ux.intel.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     davem@...emloft.net, fenghua.yu@...el.com, vkoul@...nel.org,
        dave.jiang@...el.com, tony.luck@...el.com,
        wajdi.k.feghali@...el.com, james.guilford@...el.com,
        kanchana.p.sridhar@...el.com, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH 12/16] crypto: iaa - Add support for iaa_crypto deflate
 compression algorithm

Hi Herbert,

On Fri, 2023-03-17 at 10:51 +0800, Herbert Xu wrote:
> On Mon, Mar 06, 2023 at 12:52:22PM -0600, Tom Zanussi wrote:
> > 
> > +static struct crypto_alg iaa_comp_deflate = {
> > +       .cra_name               = "deflate",
> > +       .cra_driver_name        = "iaa_crypto",
> > +       .cra_flags              = CRYPTO_ALG_TYPE_COMPRESS,
> > +       .cra_priority           = IAA_ALG_PRIORITY,
> > +       .cra_module             = THIS_MODULE,
> > +       .cra_u                  = {
> > +       .compress = {
> > +                       .coa_compress   = iaa_comp_compress,
> > +                       .coa_decompress = iaa_comp_decompress
> > +               }
> > +       }
> > +};
> 
> Please add any new code using the legacy compression interface.
> We're trying to phase them out.
> 
> If your user is still using the legacy interface, they should
> be converted instead.
> 

OK, I'll just remove this interface.  It was added so IAA could be used
with zram, which still uses the old interface.

I'll play around with seeing what it would take to get zram to use the
async interface ala zswap, but I'm guessing there may be a reason it
hasn't been converted yet...

Thanks,

Tom

> Thanks,