linux-kernel - Re: [PATCH v2 20/21] dt-bindings: pinctrl: mediatek: mt7620: split binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2023 23:38:16 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        William Dean <williamsukatube@...il.com>,
        Sean Wang <sean.wang@...nel.org>,
        Andy Teng <andy.teng@...iatek.com>,
        Del Regno <angelogioacchino.delregno@...labora.com>,
        Daniel Golle <daniel@...rotopia.org>,
        Hui Liu <hui.liu@...iatek.com>,
        Zhiyong Tao <zhiyong.tao@...iatek.com>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Daniel Santos <daniel.santos@...ox.com>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>,
        Sean Wang <sean.wang@...iatek.com>, erkin.bozoglu@...ont.com,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v2 20/21] dt-bindings: pinctrl: mediatek: mt7620: split
 binding

On 17.03.2023 22:03, Rob Herring wrote:
> On Mon, Mar 13, 2023 at 11:59:20PM +0300, arinc9.unal@...il.com wrote:
>> From: Arınç ÜNAL <arinc.unal@...nc9.com>
>>
>> The MT7628 and MT7688 SoCs contain different pin muxing information,
>> therefore, should be split. This can be done now that there are compatible
>> strings to distinguish them from other SoCs.
>>
>> Split the schema out to mediatek,mt76x8-pinctrl.yaml.
>>
>> Remove mediatek,mt76x8-pinctrl from mt7620.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
>> ---
>>   .../pinctrl/mediatek,mt7620-pinctrl.yaml      | 379 +--------------
>>   .../pinctrl/mediatek,mt76x8-pinctrl.yaml      | 450 ++++++++++++++++++
>>   2 files changed, 459 insertions(+), 370 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
>> index 808dd8bd276f..591bc0664ec6 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
>> @@ -11,15 +11,13 @@ maintainers:
>>     - Sergio Paracuellos <sergio.paracuellos@...il.com>
>>   
>>   description: |
>> -  MediaTek MT7620 pin controller for MT7620, MT7628 and MT7688 SoCs.
>> +  MediaTek MT7620 pin controller for MT7620 SoC.
> 
> Saying MT7620 twice is redundant. Otherwise,
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

It's not always a one to one relation so I'd rather explicitly point the 
SoC out like on other schemas like MT7621. Thanks for reviewing!

Arınç