linux-kernel - Re: [PATCH] dt-bindings: timer: armv7: Don't sanction address/size-cells values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f744cff0-e93d-509c-4949-fced3fa7123c@linaro.org>
Date:   Fri, 17 Mar 2023 01:20:04 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, andersson@...nel.org,
        agross@...nel.org, marijn.suijten@...ainline.org,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Marc Zyngier <maz@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: armv7: Don't sanction
 address/size-cells values



On 16.03.2023 23:47, Rob Herring wrote:
> On Wed, Mar 08, 2023 at 02:28:53AM +0100, Konrad Dybcio wrote:
>> The driver itself does not read the -cells values (and frankly, it
>> shouldn't), 
> 
> Agreed, because this is standard address translation and only the DT 
> core address functions should read cells props.
> 
>> so there's little sense in only allowing [1, 2] x [1].
> 
> Why does the timer need 64-bits of address space? It doesn't, so that's 
> the reason for restricting it.
> 
>> Allow any values.
>>
>> Fixes: 4d2bb3e65035 ("dt-bindings: timer: Convert ARM timer bindings to json-schema")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> ---
>>  .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml      | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
>> index f6efa48c4256..236e2a05c1ad 100644
>> --- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
>> +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
>> @@ -26,11 +26,9 @@ properties:
>>      maxItems: 1
>>      description: The control frame base address
>>  
>> -  '#address-cells':
>> -    enum: [1, 2]
>> +  '#address-cells': true
> 
> So 3 address cells is valid?
> 
> Until recently (and not yet in a dtschema release), there was no 
> constraint on #address-cells or #size-cells values other than the 
> #.*-cells constraint of 8. Now it is 3 and 2.
Okay, I didn't know that. I suppose we can forget about this patch.

Konrad
> 
>>  
>> -  '#size-cells':
>> -    const: 1
>> +  '#size-cells': true
>>  
>>    ranges: true
>>  
>> -- 
>> 2.39.2
>>