linux-kernel - Re: [Patch v3 7/7] KVM: x86/mmu: Merge all handle_changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHVum0fM3CLda98e-nBP6yPBLkRvBhUq=iZqZGCC_6jT08SM0Q@mail.gmail.com>
Date:   Fri, 17 Mar 2023 16:48:49 -0700
From:   Vipin Sharma <vipinsh@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     pbonzini@...hat.com, bgardon@...gle.com, dmatlack@...gle.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch v3 7/7] KVM: x86/mmu: Merge all handle_changed_pte* functions.

On Fri, Mar 17, 2023 at 3:51 PM Sean Christopherson <seanjc@...gle.com> wrote:
>
> On Fri, Feb 10, 2023, Vipin Sharma wrote:
> > @@ -1301,7 +1283,7 @@ bool kvm_tdp_mmu_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
> >       /*
> >        * No need to handle the remote TLB flush under RCU protection, the
> >        * target SPTE _must_ be a leaf SPTE, i.e. cannot result in freeing a
> > -      * shadow page.  See the WARN on pfn_changed in __handle_changed_spte().
> > +      * shadow page. See the WARN on pfn_changed in handle_changed_spte().
>
> I was just starting to think you're an ok person, and then I find out you're a
> heretic that only puts a single space after periods.  ;-)

I know, I know, I can't help it. I just love the way single space
looks after periods.