linux-kernel - Re: [PATCH v8] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJedcCzCq72UdFyuLJHP-cH-KzmhtA3EERGXSzdXnosOXqWYiA@mail.gmail.com>
Date:   Fri, 17 Mar 2023 12:09:58 +0800
From:   Zheng Hacker <hackerzheng666@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Zheng Wang <zyytlz.wz@....com>, skhan@...uxfoundation.org,
        p.zabel@...gutronix.de, biju.das.jz@...renesas.com,
        phil.edworthy@...esas.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, 1395428693sheep@...il.com,
        alex000young@...il.com, yoshihiro.shimoda.uh@...esas.com
Subject: Re: [PATCH v8] usb: gadget: udc: renesas_usb3: Fix use after free bug
 in renesas_usb3_remove due to race condition

Greg KH <gregkh@...uxfoundation.org> 于2023年3月17日周五 03:07写道：
>
> On Fri, Mar 17, 2023 at 02:16:23AM +0800, Zheng Wang wrote:
> > In renesas_usb3_probe, role_work is bound with renesas_usb3_role_work.
> > renesas_usb3_start will be called to start the work.
> >
> > If we remove the driver which will call usbhs_remove, there may be
> > an unfinished work. The possible sequence is as follows:
> >
> > Fix it by canceling the work before cleanup in the renesas_usb3_remove.
> >
> > Note that removing a driver is a root-only operation, and should never
> > happen.
> >
> > CPU0                                          CPU1
> >
> >                                        renesas_usb3_role_work
> > renesas_usb3_remove
> > usb_role_switch_unregister
> > device_unregister
> > kfree(sw)
> > free usb3->role_sw
> >                                        usb_role_switch_set_role
> >                                        //use usb3->role_sw
>
> No line at all?
>

Sorry, I'll remove the empty line. And I think there are other ways to
trigger device's remove like directly unpluging the USB device if
accessible. I think we nee to append this msg in the next version.

Best regards,
Zheng