linux-kernel - Re: [PATCH net] i825xx: sni_82596: use eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230316173635.049ee5f4@kernel.org>
Date:   Thu, 16 Mar 2023 17:36:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kubiak <michal.kubiak@...el.com>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] i825xx: sni_82596: use eth_hw_addr_set()

On Wed, 15 Mar 2023 19:12:03 +0100 Michal Kubiak wrote:
> The fix looks fine. Good catch!
> I would only suggest to add more description why it needed to be
> changed.
> (The current version of the commit message only contains information what
> was done, but it is quite obvious by looking at the code).

Let me make an exception and add that info myself.. since I broke this
:)