linux-kernel - Re: [PATCH v18 2/3] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230317080321.GC9667@google.com>
Date:   Fri, 17 Mar 2023 08:03:21 +0000
From:   Lee Jones <lee@...nel.org>
To:     ChiaEn Wu <chiaen_wu@...htek.com>
Cc:     corbet@....net, pavel@....cz, matthias.bgg@...il.com,
        andriy.shevchenko@...ux.intel.com, jacek.anaszewski@...il.com,
        angelogioacchino.delregno@...labora.com, linux-doc@...r.kernel.org,
        peterwu.pub@...il.com, cy_huang@...htek.com,
        linux-leds@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        szunichen@...il.com, Alice Chen <alice_chen@...htek.com>
Subject: Re: [PATCH v18 2/3] leds: flash: mt6370: Add MediaTek MT6370
 flashlight support

On Fri, 17 Mar 2023, Lee Jones wrote:

> On Fri, 10 Mar 2023, ChiaEn Wu wrote:
>
> > From: ChiYuan Huang <cy_huang@...htek.com>
> >
> > The MediaTek MT6370 is a highly-integrated smart power management IC,
> > which includes a single cell Li-Ion/Li-Polymer switching battery
> > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash
> > LED current sources, a RGB LED driver, a backlight WLED driver,
> > a display bias driver and a general LDO for portable devices.
> >
> > Add support for the MT6370 Flash LED driver. Flash LED in MT6370
> > has 2 channels and support torch/strobe mode.
> >
> > Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> > Co-developed-by: Alice Chen <alice_chen@...htek.com>
> > Signed-off-by: Alice Chen <alice_chen@...htek.com>
> > Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> > Signed-off-by: ChiaEn Wu <chiaen_wu@...htek.com>
> > ---
> > v18:
> > - Unwrap each line by 100 chars limit.
> > - For joint flash, add more comments above the source code.
> > - Remove 'sentinel' comment in of_device_id table declaration.
> > ---
> >  drivers/leds/flash/Kconfig             |  13 +
> >  drivers/leds/flash/Makefile            |   1 +
> >  drivers/leds/flash/leds-mt6370-flash.c | 573 +++++++++++++++++++++++++++++++++
> >  3 files changed, 587 insertions(+)
> >  create mode 100644 drivers/leds/flash/leds-mt6370-flash.c
>
> Applied, thanks

Next time, please make checkpatch.pl happy before submitting.

--
Lee Jones [李琼斯]