linux-kernel - Re: [PATCH] drm/format-helper: Use drm_format_info_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2023 09:08:09 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     dri-devel@...ts.freedesktop.org,
        Maíra Canal <mairacanal@...eup.net>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        David Gow <davidgow@...gle.com>,
        José Expósito <jose.exposito89@...il.com>,
        Arthur Grillo <arthurgrillo@...eup.net>
Subject: Re: [PATCH] drm/format-helper: Use drm_format_info_min_pitch() in
 tests helper



Am 16.03.23 um 23:34 schrieb Javier Martinez Canillas:
> There's a nice macro to calculate the destination pitch that already takes
> into account sub-byte pixel formats. Use that instead of open coding it.
> 
> Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
> 
>   drivers/gpu/drm/tests/drm_format_helper_test.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
> index bfa47f8ffd09..474bb7a1c4ee 100644
> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
> @@ -440,15 +440,12 @@ static size_t conversion_buf_size(u32 dst_format, unsigned int dst_pitch,
>   				  const struct drm_rect *clip)
>   {
>   	const struct drm_format_info *dst_fi = drm_format_info(dst_format);
> -	unsigned int bpp;
>   
>   	if (!dst_fi)
>   		return -EINVAL;
>   
> -	if (!dst_pitch) {
> -		bpp = drm_format_info_bpp(dst_fi, 0);
> -		dst_pitch = DIV_ROUND_UP(drm_rect_width(clip) * bpp, 8);
> -	}
> +	if (!dst_pitch)
> +		dst_pitch = drm_format_info_min_pitch(dst_fi, 0, drm_rect_width(clip));
>   
>   	return dst_pitch * drm_rect_height(clip);
>   }
> 
> base-commit: 165d5133731a2e045abdd6d9d3c9221fdc2a556e

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)