linux-kernel - Re: [PATCH 05/37] drm/ttm/ttm_bo: Provide a missing 'bulk' description and correct misnaming of 'placement'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30f75b09-fdc6-bb3c-0785-f7b0f3183192@amd.com>
Date:   Fri, 17 Mar 2023 09:40:49 +0100
From:   Christian König <christian.koenig@....com>
To:     Lee Jones <lee@...nel.org>, dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org, Huang Rui <ray.huang@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        linux-media@...r.kernel.org, linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH 05/37] drm/ttm/ttm_bo: Provide a missing 'bulk'
 description and correct misnaming of 'placement'

Am 17.03.23 um 09:16 schrieb Lee Jones:
> 'bulk' description taken from another in the same file.
>
> Fixes the following W=1 kernel build warning(s):
>
>   drivers/gpu/drm/ttm/ttm_bo.c:98: warning: Function parameter or member 'bulk' not described in 'ttm_bo_set_bulk_move'
>   drivers/gpu/drm/ttm/ttm_bo.c:768: warning: Function parameter or member 'placement' not described in 'ttm_bo_mem_space'
>   drivers/gpu/drm/ttm/ttm_bo.c:768: warning: Excess function parameter 'proposed_placement' description in 'ttm_bo_mem_space'
>
> Cc: Christian Koenig <christian.koenig@....com>
> Cc: Huang Rui <ray.huang@....com>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-media@...r.kernel.org
> Cc: linaro-mm-sig@...ts.linaro.org
> Signed-off-by: Lee Jones <lee@...nel.org>

Reviewed-by: Christian König <christian.koenig@....com>

Going to upstream that through drm-misc-next in a minute.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 459f1b4440daa..d056d28f8758a 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -84,6 +84,7 @@ EXPORT_SYMBOL(ttm_bo_move_to_lru_tail);
>    * ttm_bo_set_bulk_move - update BOs bulk move object
>    *
>    * @bo: The buffer object.
> + * @bulk: bulk move structure
>    *
>    * Update the BOs bulk move object, making sure that resources are added/removed
>    * as well. A bulk move allows to move many resource on the LRU at once,
> @@ -748,7 +749,7 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,
>    *
>    * @bo: Pointer to a struct ttm_buffer_object. the data of which
>    * we want to allocate space for.
> - * @proposed_placement: Proposed new placement for the buffer object.
> + * @placement: Proposed new placement for the buffer object.
>    * @mem: A struct ttm_resource.
>    * @ctx: if and how to sleep, lock buffers and alloc memory
>    *