linux-kernel - Re: [PATCH 37/37] drm/bridge/imx/Kconfig: Prevent imx-ldb-helper from appearing in 2 separate modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc8b6ec1f05c1514b6ed5535e16c9c2d21efea86.camel@nxp.com>
Date:   Fri, 17 Mar 2023 17:42:21 +0800
From:   Liu Ying <victor.liu@....com>
To:     Lee Jones <lee@...nel.org>, dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 37/37] drm/bridge/imx/Kconfig: Prevent imx-ldb-helper
 from appearing in 2 separate modules

Hi Lee,

On Fri, 2023-03-17 at 08:17 +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  scripts/Makefile.build:252: drivers/gpu/drm/bridge/imx/Makefile: imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldb
> 
> Cc: Liu Ying <victor.liu@....com>
> Cc: Andrzej Hajda <andrzej.hajda@...el.com>
> Cc: Neil Armstrong <neil.armstrong@...aro.org>
> Cc: Robert Foss <rfoss@...nel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@...asonboard.com>
> Cc: Jonas Karlman <jonas@...boo.se>
> Cc: Jernej Skrabec <jernej.skrabec@...il.com>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Pengutronix Kernel Team <kernel@...gutronix.de>
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: NXP Linux Team <linux-imx@....com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Lee Jones <lee@...nel.org>

Thank you for the patch.

> ---
>  drivers/gpu/drm/bridge/imx/Kconfig          |  7 +++++++
>  drivers/gpu/drm/bridge/imx/Makefile         |  7 +++++--
>  drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 +++++++++++++
>  3 files changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig
> index 608f47f41bcd1..97018dcd078d0 100644
> --- a/drivers/gpu/drm/bridge/imx/Kconfig
> +++ b/drivers/gpu/drm/bridge/imx/Kconfig
> @@ -1,10 +1,16 @@
>  if ARCH_MXC || COMPILE_TEST
>  
> +config DRM_IMX8_LIB

I would limit this to i.MX LVDS Display Bridge(LDB) library, so I
suggest to use DRM_IMX_LDB_LIB.

> +	tristate
> +	help
> +	  Common helper functions used by some of the drivers below.

Considering to use DRM_IMX_LDB_LIB, help message can be a bit more
specific to LDB drivers, like:

Common helper functions used by i.MX LVDS display bridge drivers below.

Regards,
Liu Ying