linux-kernel - Re: [PATCH v2] mm/slub: fix help comment of SLUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab97a4bf-b89a-0c8e-f871-d5f2b3dfa645@suse.cz>
Date:   Fri, 17 Mar 2023 12:04:19 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Vernon Yang <vernon2gm@...il.com>, akpm@...ux-foundation.org,
        42.hyeyoo@...il.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/slub: fix help comment of SLUB_DEBUG

On 3/14/23 08:16, Vernon Yang wrote:
> Since commit ab4d5ed5eeda ("slub: Enable sysfs support for
> !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables
> SLUB sysfs support that is not true anymore, so fix it correctly.
> 
> Signed-off-by: Vernon Yang <vernon2gm@...il.com>

Thanks, slightly reworded and pushed to slab/for-6.4/trivial

> ---
>  mm/Kconfig.debug | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index c3547a373c9c..9a90a88ce053 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -60,9 +60,8 @@ config SLUB_DEBUG
>  	select STACKDEPOT if STACKTRACE_SUPPORT
>  	help
>  	  SLUB has extensive debug support features. Disabling these can
> -	  result in significant savings in code size. This also disables
> -	  SLUB sysfs support. /sys/slab will not exist and there will be
> -	  no support for cache validation etc.
> +	  result in significant savings in code size, the /sys/kernel/slab
> +	  will exist but will not provide e.g. cache validation.
>  
>  config SLUB_DEBUG_ON
>  	bool "SLUB debugging on by default"