linux-kernel - Re: [PATCH 2/2] bindings: regulator: pca9450: Add LOADSW regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae7c1d45-8e19-dc96-6769-c0b37791132d@kernel.org>
Date:   Fri, 17 Mar 2023 12:49:43 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Nicolas Heemeryck <nicolas.heemeryck@...ialet.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] bindings: regulator: pca9450: Add LOADSW regulator

On 17/03/2023 10:39, Nicolas Heemeryck wrote:
> Add the binding documentation for the load switch regulator.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed important mailing lists as well, thus patch won't be tested.
That's a NAK. :(

> 
> Signed-off-by: Nicolas Heemeryck <nicolas.heemeryck@...ialet.com>
> ---
>  .../bindings/regulator/nxp,pca9450-regulator.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> index 835b53302db8..064d57256aff 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> @@ -20,6 +20,7 @@ description: |
>  #The valid names for PCA9450 regulator nodes are:
>  #BUCK1, BUCK2, BUCK3, BUCK4, BUCK5, BUCK6,
>  #LDO1, LDO2, LDO3, LDO4, LDO5
> +#LOADSW
>  #Note: Buck3 removed on PCA9450B and connect with Buck1 on PCA9450C.
>  
>  properties:
> @@ -74,6 +75,14 @@ properties:
>  
>          unevaluatedProperties: false
>  
> +        "LOADSW":

Does not look like pattern... unless you want something-LOADSW, but then
why?



Best regards,
Krzysztof