linux-kernel - Re: [PATCH bpf-next] kallsyms: move find_kallsyms_symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167905741806.12724.17197641552332492380.git-patchwork-notify@kernel.org>
Date:   Fri, 17 Mar 2023 12:50:18 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Viktor Malik <vmalik@...hat.com>
Cc:     bpf@...r.kernel.org, mcgrof@...nel.org, ast@...nel.org,
        daniel@...earbox.net, john.fastabend@...il.com, andrii@...nel.org,
        martin.lau@...ux.dev, song@...nel.org, yhs@...com,
        kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, linux-modules@...r.kernel.org,
        linux-kernel@...r.kernel.org, lkp@...el.com
Subject: Re: [PATCH bpf-next] kallsyms: move find_kallsyms_symbol_value out of
 internal header

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@...earbox.net>:

On Fri, 17 Mar 2023 10:56:01 +0100 you wrote:
> Moving find_kallsyms_symbol_value from kernel/module/internal.h to
> include/linux/module.h. The reason is that internal.h is not prepared to
> be included when CONFIG_MODULES=n. find_kallsyms_symbol_value is used by
> kernel/bpf/verifier.c and including internal.h from it (without modules)
> leads into a compilation error:
> 
> In file included from ../include/linux/container_of.h:5,
>                  from ../include/linux/list.h:5,
>                  from ../include/linux/timer.h:5,
>                  from ../include/linux/workqueue.h:9,
>                  from ../include/linux/bpf.h:10,
>                  from ../include/linux/bpf-cgroup.h:5,
>                  from ../kernel/bpf/verifier.c:7:
> ../kernel/bpf/../module/internal.h: In function 'mod_find':
> ../include/linux/container_of.h:20:54: error: invalid use of undefined type 'struct module'
>    20 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
>       |                                                      ^~
> [...]
> 
> [...]

Here is the summary with links:
  - [bpf-next] kallsyms: move find_kallsyms_symbol_value out of internal header
    https://git.kernel.org/bpf/bpf-next/c/bd5314f8dd2d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html