linux-kernel - Re: [PATCH] powerpc/pseries: Fix exception handling in pSeries_reconfig_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <871qln8quw.fsf@linux.ibm.com>
Date:   Fri, 17 Mar 2023 08:11:35 -0500
From:   Nathan Lynch <nathanl@...ux.ibm.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     cocci@...ia.fr, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Paul Moore <paul@...l-moore.com>
Subject: Re: [PATCH] powerpc/pseries: Fix exception handling in
 pSeries_reconfig_add_node()

Markus Elfring <Markus.Elfring@....de> writes:
>
> The label “out_err” was used to jump to another pointer check despite of
> the detail in the implementation of the function “pSeries_reconfig_add_node”
> that it was determined already that the corresponding variable contained
> a null pointer (because of a failed function call in two cases).
>
> 1. Thus return directly after a call of the function “kzalloc” failed.
>
> 2. Use more appropriate labels instead.
>
> 3. Delete a redundant check.
>
> 4. Omit an explicit initialisation for the local variable “err”.
>
> This issue was detected by using the Coccinelle software.

Is there a correctness or safety issue here? The subject uses the word
"fix" but the commit message doesn't seem to identify one.

Can you share how Coccinelle is being invoked and its output?