linux-kernel - Re: [PATCH 1/2] platform/x86/intel/pmt: Add INTEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcB9vokGSZ6ZCqyuNGfVWpn8vdTeLyHSO9MiuSoXR8tqw@mail.gmail.com>
Date:   Fri, 17 Mar 2023 15:34:21 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "David E. Box" <david.e.box@...ux.intel.com>
Cc:     irenic.rajneesh@...il.com, david.e.box@...el.com,
        hdegoede@...hat.com, markgross@...nel.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 1/2] platform/x86/intel/pmt: Add INTEL_PMT module namespace

On Fri, Mar 17, 2023 at 12:57 AM David E. Box
<david.e.box@...ux.intel.com> wrote:
>
> Since the currently exported symbols in pmt_class are only used by other
> Intel PMT drivers, create an INTEL_PMT module namespace for them.

Makes sense.
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> ---
>  drivers/platform/x86/intel/pmt/class.c     | 6 +++---
>  drivers/platform/x86/intel/pmt/crashlog.c  | 1 +
>  drivers/platform/x86/intel/pmt/telemetry.c | 1 +
>  3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c
> index 46598dcb634a..0b96d75f5924 100644
> --- a/drivers/platform/x86/intel/pmt/class.c
> +++ b/drivers/platform/x86/intel/pmt/class.c
> @@ -33,7 +33,7 @@ bool intel_pmt_is_early_client_hw(struct device *dev)
>          */
>         return !!(ivdev->info->quirks & VSEC_QUIRK_EARLY_HW);
>  }
> -EXPORT_SYMBOL_GPL(intel_pmt_is_early_client_hw);
> +EXPORT_SYMBOL_NS_GPL(intel_pmt_is_early_client_hw, INTEL_PMT);
>
>  static inline int
>  pmt_memcpy64_fromio(void *to, const u64 __iomem *from, size_t count)
> @@ -327,7 +327,7 @@ int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespa
>         return intel_pmt_dev_register(entry, ns, dev);
>
>  }
> -EXPORT_SYMBOL_GPL(intel_pmt_dev_create);
> +EXPORT_SYMBOL_NS_GPL(intel_pmt_dev_create, INTEL_PMT);
>
>  void intel_pmt_dev_destroy(struct intel_pmt_entry *entry,
>                            struct intel_pmt_namespace *ns)
> @@ -343,7 +343,7 @@ void intel_pmt_dev_destroy(struct intel_pmt_entry *entry,
>         device_unregister(dev);
>         xa_erase(ns->xa, entry->devid);
>  }
> -EXPORT_SYMBOL_GPL(intel_pmt_dev_destroy);
> +EXPORT_SYMBOL_NS_GPL(intel_pmt_dev_destroy, INTEL_PMT);
>
>  static int __init pmt_class_init(void)
>  {
> diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x86/intel/pmt/crashlog.c
> index ace1239bc0a0..bbb3d61d09f4 100644
> --- a/drivers/platform/x86/intel/pmt/crashlog.c
> +++ b/drivers/platform/x86/intel/pmt/crashlog.c
> @@ -328,3 +328,4 @@ module_exit(pmt_crashlog_exit);
>  MODULE_AUTHOR("Alexander Duyck <alexander.h.duyck@...ux.intel.com>");
>  MODULE_DESCRIPTION("Intel PMT Crashlog driver");
>  MODULE_LICENSE("GPL v2");
> +MODULE_IMPORT_NS(INTEL_PMT);
> diff --git a/drivers/platform/x86/intel/pmt/telemetry.c b/drivers/platform/x86/intel/pmt/telemetry.c
> index 5e4009c05ecf..71cdef42084a 100644
> --- a/drivers/platform/x86/intel/pmt/telemetry.c
> +++ b/drivers/platform/x86/intel/pmt/telemetry.c
> @@ -160,3 +160,4 @@ module_exit(pmt_telem_exit);
>  MODULE_AUTHOR("David E. Box <david.e.box@...ux.intel.com>");
>  MODULE_DESCRIPTION("Intel PMT Telemetry driver");
>  MODULE_LICENSE("GPL v2");
> +MODULE_IMPORT_NS(INTEL_PMT);
>
> base-commit: 79df06733435e2773eb5e9ab9c0ce13c23e4cd88
> --
> 2.34.1
>


-- 
With Best Regards,
Andy Shevchenko